[
https://issues.apache.org/jira/browse/THRIFT-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563741#comment-16563741
]
ASF GitHub Bot commented on THRIFT-4605:
----------------------------------------
jeking3 closed pull request #1574: THRIFT-4605: bootstrap.sh fails if
automake=1.16.1
URL: https://github.com/apache/thrift/pull/1574
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bootstrap.sh b/bootstrap.sh
index c7e000c49f..2452eea448 100755
--- a/bootstrap.sh
+++ b/bootstrap.sh
@@ -38,10 +38,14 @@ else
exit 1
fi
+format_version () {
+ printf "%03d%03d%03d%03d" $(echo $1 | tr '.' ' ');
+}
+
# we require automake 1.13 or later
# check must happen externally due to use of newer macro
AUTOMAKE_VERSION=`automake --version | grep automake | egrep -o
'([0-9]{1,}\.)+[0-9]{1,}'`
-if [ "$AUTOMAKE_VERSION" \< "1.13" ]; then
+if [ $(format_version $AUTOMAKE_VERSION) -lt $(format_version 1.13) ]; then
echo >&2 "automake version $AUTOMAKE_VERSION is too old (need 1.13 or later)"
exit 1
fi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> bootstrap.sh fails if automake=1.16.1
> -------------------------------------
>
> Key: THRIFT-4605
> URL: https://issues.apache.org/jira/browse/THRIFT-4605
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.11.0
> Reporter: Jaume M
> Priority: Minor
>
> With automake version 1.16.1 is too old (need 1.13 or later)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
