[
https://issues.apache.org/jira/browse/THRIFT-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565258#comment-16565258
]
ASF GitHub Bot commented on THRIFT-4604:
----------------------------------------
jeking3 closed pull request #1573: THRIFT-4604: NodeJS: adds Int64 to exports
for browserify
URL: https://github.com/apache/thrift/pull/1573
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lib/nodejs/lib/thrift/browser.js b/lib/nodejs/lib/thrift/browser.js
index 4593a8fd15..67ce8535be 100644
--- a/lib/nodejs/lib/thrift/browser.js
+++ b/lib/nodejs/lib/thrift/browser.js
@@ -32,3 +32,5 @@ exports.TFramedTransport = require('./framed_transport');
exports.Protocol = exports.TJSONProtocol = require('./json_protocol');
exports.TBinaryProtocol = require('./binary_protocol');
exports.TCompactProtocol = require('./compact_protocol');
+
+exports.Int64 = require('node-int64');
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NodeJS: Expose Int64 from browser.js for consumption by browser
> ---------------------------------------------------------------
>
> Key: THRIFT-4604
> URL: https://issues.apache.org/jira/browse/THRIFT-4604
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Kevin Greene
> Priority: Minor
> Fix For: 0.12.0
>
>
> When using the Node.js libs in the browser (via browser.js) Int64 isn't
> exposed the same way as it is in a Node environment. This just adds Int64 to
> the exports in browser.js to make consuming the libs more consistent with how
> we do in an actual Node environment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
