[
https://issues.apache.org/jira/browse/THRIFT-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570814#comment-16570814
]
ASF GitHub Bot commented on THRIFT-4609:
----------------------------------------
Jens-G opened a new pull request #1576: THRIFT-4609 keep InnerException
wherever appropriate
URL: https://github.com/apache/thrift/pull/1576
Client: C#
Patch: Jens Geyer
Some helpful tips for a successful Apache Thrift PR:
* Did you test your changes locally or using CI in your fork?
* Is the Apache Jira THRIFT ticket identifier in the PR title?
* Is the Apache Jira THRIFT ticket identifier in the commit message?
* Did you squash your changes to a single commit?
* Are these changes backwards compatible? (please say so in PR description)
* Do you need to update the language-specific README?
Example ideal pull request title:
THRIFT-9999: an example pull request title
Example ideal commit message:
THRIFT-9999: [summary of fix, one line if possible]
Client: [language(s) affected, comma separated, use lib/ directory
names please]
For more information about committing, see CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> keep InnerException wherever appropriate
> -----------------------------------------
>
> Key: THRIFT-4609
> URL: https://issues.apache.org/jira/browse/THRIFT-4609
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
>
> The C# {{Exception}} type offers the ability to store an {{InnerException}}
> which is sometimes quite helpful for debugging. Hence, wherever appropriate,
> any exceptions caught and rethrown should be stored into the
> {{InnerException}} field to provide the original error information to the
> caller.
> The only exception (pun intended) to this is {{TApplicationException}} - this
> type is intended to be serialized and sent back to the client. Not only that
> there is no way to preserve that information, it also [could compromise
> possibly sensitive information to clients, which is a bad thing to happen
> w/regard to security|https://cwe.mitre.org/data/definitions/209.html].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
