[ https://issues.apache.org/jira/browse/THRIFT-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593081#comment-16593081 ]
ASF GitHub Bot commented on THRIFT-4621: ---------------------------------------- nsuke commented on a change in pull request #1583: THRIFT-4621 Add THeader for Python URL: https://github.com/apache/thrift/pull/1583#discussion_r212813394 ########## File path: lib/py/src/protocol/THeaderProtocol.py ########## @@ -31,6 +31,31 @@ class THeaderProtocol(TProtocolBase): + """A framed protocol with headers and payload transforms. + + THeaderProtocol frames other Thrift protocols and adds support for optional + out-of-band headers. The currently supported subprotocols are + TBinaryProtocol and TCompactProtocol. + + It's also possible to apply transforms to the encoded message payload. The + only transform currently supported is to gzip. + + When used in a server, THeaderProtocol can accept messages from + non-THeaderProtocol clients if allowed (see `allowed_client_types`). This + includes framed and unframed transports and both TBinaryProtocol and + TCompactProtocol. The server will respond in the appropriate dialect for + the connected client. HTTP clients are not currently supported. + + To achieve all of the above, THeaderProtocol manages its own buffering. + It's best not to use it with TBufferedTransport. + + THeaderProtocol does not currently support THTTPServer, TNonblockingServer, + or TProcessPoolServer. + + See doc/specs/HeaderFormat.md for details of the wire format. + + """ Review comment: great, thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > THeader for Python > ------------------ > > Key: THRIFT-4621 > URL: https://issues.apache.org/jira/browse/THRIFT-4621 > Project: Thrift > Issue Type: New Feature > Components: Python - Library > Reporter: Neil Williams > Priority: Minor > > I'm interested in porting THeader for the Python library. If that sounds OK, > I'll have a PR ready in not too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005)