[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653365#comment-16653365 ]
ASF GitHub Bot commented on THRIFT-4382: ---------------------------------------- djzort opened a new pull request #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613 Some helpful tips for a successful Apache Thrift PR: * Did you test your changes locally or using CI in your fork? * Is the Apache Jira THRIFT ticket identifier in the PR title? * Is the Apache Jira THRIFT ticket identifier in the commit message? * Did you squash your changes to a single commit? * Are these changes backwards compatible? (please say so in PR description) * Do you need to update the language-specific README? Example ideal pull request title: THRIFT-9999: an example pull request title Example ideal commit message: THRIFT-9999: [summary of fix, one line if possible] Client: [language(s) affected, comma separated, use lib/ directory names please] For more information about committing, see CONTRIBUTING.md Using Indirect Object Syntax to instantiate objects is not recommended as per https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods I have update the output to follow the recommended Class->new() syntax See also https://github.com/apache/thrift/pull/1261 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -------------------------------------------------------------- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler > Reporter: Dean Hamstead > Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)