[
https://issues.apache.org/jira/browse/THRIFT-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655691#comment-16655691
]
ASF GitHub Bot commented on THRIFT-4653:
----------------------------------------
bforbis commented on issue #1615: THRIFT-4653: ES6 classes support
URL: https://github.com/apache/thrift/pull/1615#issuecomment-431109015
I'll have to look into this later this weekend. Is this `EnumTest.thrift`
file supposed to be a passing test case? The code it generates does not compile
for me, as some of the key literals for the generated objects are invalid
(negative integer literals, array literals).
This is true for the current thrift 11 as well, so I'm not sure if this was
ever expected to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ES6 Classes
> -----------
>
> Key: THRIFT-4653
> URL: https://issues.apache.org/jira/browse/THRIFT-4653
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, Node.js - Compiler
> Reporter: Brian Forbis
> Priority: Minor
>
> Updating the generated code to generate ES6 classes when using the es6
> compiler option. ES6 classes should be a drop in replacement for manual ES5
> prototypical inheritance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
