[
https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676809#comment-16676809
]
ASF GitHub Bot commented on THRIFT-4654:
----------------------------------------
jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2
compatibility (backwards compatible)
URL: https://github.com/apache/thrift/pull/1617#issuecomment-436266285
I am going to commit some changes to master to fix the sca build job. It
doesn't affect dart anyway so we can ignore it. I noticed when I "make
precross" locally I see:
```
jking@ubuntu:~/thrift$ git status
On branch dart2
Your branch is up to date with 'robbecker/dart2'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
lib/dart/.dart_tool/
test/dart/test_client/.dart_tool/
```
It looks like we need to exclude `**/.dart_tool` in `.gitignore`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Thrift Dart port is not compatible with Dart 2
> ----------------------------------------------
>
> Key: THRIFT-4654
> URL: https://issues.apache.org/jira/browse/THRIFT-4654
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Environment: Any OS, under Dart 2+
> Reporter: Rob Becker
> Assignee: James E. King III
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires
> opting in via a setting in the pubspec.yaml and the code needs to update the
> use of all caps constant names to the new camel case names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
