Does this mean this is a breaking change? If you have to modify the cross tests...
On Sun, Nov 11, 2018 at 10:35 AM ASF GitHub Bot (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682909#comment-16682909 > ] > > ASF GitHub Bot commented on THRIFT-4529: > ---------------------------------------- > > allengeorge commented on issue #1625: THRIFT-4529: Camel-case enum variants > URL: https://github.com/apache/thrift/pull/1625#issuecomment-437680138 > > > Build failure caused by a PEBCAK on my part (forgot to change enum > variant names in cross-tests). Fixing now. > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > > Rust generation should include #![allow(non_snake_case)] or force > conform to Rust style guidelines > > > -------------------------------------------------------------------------------------------------- > > > > Key: THRIFT-4529 > > URL: https://issues.apache.org/jira/browse/THRIFT-4529 > > Project: Thrift > > Issue Type: Improvement > > Components: Rust - Compiler > > Affects Versions: 0.11.0 > > Reporter: Joshua > > Assignee: Allen George > > Priority: Minor > > > > Without this, building a project using a thrift file meant for multiple > languages may end up with many compiler warnings similar to the following: > > {code:sh} > > warning: variant `EXAMPLE_NAME` should have a camel case name such as > `ExampleName` > > {code} > > > > -- > This message was sent by Atlassian JIRA > (v7.6.3#76005) >
