[
https://issues.apache.org/jira/browse/THRIFT-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684690#comment-16684690
]
ASF GitHub Bot commented on THRIFT-4656:
----------------------------------------
sokac commented on issue #1618: THRIFT-4656: Fix infinite loop in PHP
TCurlClient
URL: https://github.com/apache/thrift/pull/1618#issuecomment-438122866
@jeking3 I updated PR. You were right about oneway - server returns 200 OK
with empty body. Looks like
https://github.com/apache/thrift/pull/1602/files#diff-74eb8d4b20c423c78252e3e3dc847099R227
unintentionally fixed a bug, and the original version of this PR would have
broken it.
I tested with simple service that has both oneway and regular functions,
everything was fully functional. I noticed php client will block until it gets
response, but that's a different problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> infinite loop in latest PHP library
> -----------------------------------
>
> Key: THRIFT-4656
> URL: https://issues.apache.org/jira/browse/THRIFT-4656
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Reporter: Josip Sokcevic
> Priority: Major
> Fix For: 0.12.0
>
> Attachments:
> 0001-THRIFT-4656-Fix-infinite-loop-in-PHP-TCurlClient.patch
>
>
> The latest PHP library can enter into infinite loop state when specific
> payload is returned:
> HTTP status: 200
> Response body: <empty>
>
> It was introduced with THRIFT-4645, where check was replaced from
> {code:java}
> !$this->response_{code}
> to
> {code:java}
> $this->response_ === false{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
