[
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697155#comment-16697155
]
ASF GitHub Bot commented on THRIFT-3143:
----------------------------------------
jeking3 commented on issue #1630: THRIFT-3143: Add nodets support
URL: https://github.com/apache/thrift/pull/1630#issuecomment-441246486
You can run the cross test locally if you use the docker build container.
First you prepare the environment:
```
user@ubuntu:~/thrift$ docker pull thrift/thrift-build:ubuntu-bionic
user@ubuntu:~/thrift$ docker run -v $(pwd):/thrift/src:rw -it
thrift/thrift-build:ubuntu-bionic /bin/bash
root@8d4584e2e789:/thrift/src# ./bootstrap.sh
root@8d4584e2e789:/thrift/src# ./configure
root@8d4584e2e789:/thrift/src# make precross
```
Next you can run a specific combination of tests:
```
root@8d4584e2e789:/thrift/src# test/test.py --retry-count 5
--skip-known-failures --server cpp --client nodets
```
That will help you prepare your next pull request for success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add typescript directory support
> --------------------------------
>
> Key: THRIFT-3143
> URL: https://issues.apache.org/jira/browse/THRIFT-3143
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Compiler
> Reporter: Kazuki Yasufuku
> Priority: Major
>
> Current typescript support is only work for browser, and generated d.ts uses
> internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code
> directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
