[
https://issues.apache.org/jira/browse/THRIFT-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733151#comment-16733151
]
Renan DelValle commented on THRIFT-4453:
----------------------------------------
> Yes, 0.11 had more BC breaks but this ticket is specifically about context
>support, which does take a few minutes to update. I know because I did just
>that for a service with 100+ RPCs.
Fair, but what I'm getting at is you can't verify that the change worked until
you finish fixing all breaking changes. If you don't mind sharing and
documenting how you accomplished this in such a short time it would really ease
the pain of transition.
> Most importantly it provides cancellation support, but it's useful for
> passing transport related information to the handlers, like client IP.
I understand this is the intended use but can you please point me to where it
is being used as such since being introduced to code base more than a year ago?
As far as I can tell it is not being passed down to the transport layer at all.
> Go generator flag to turn off Context parameter
> -----------------------------------------------
>
> Key: THRIFT-4453
> URL: https://issues.apache.org/jira/browse/THRIFT-4453
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.11.0
> Reporter: Renan DelValle
> Priority: Minor
>
> It would be worthwhile to be able to pass a argument to the code generator
> for Go that allows to disable the addition of the Context parameter to each
> function signature that was included with the 0.11.0 release. This is to
> avoid backwards incompatible code generation in cases where developers don't
> require context.
> This flag could be as simple as `-disable-context`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
