[ https://issues.apache.org/jira/browse/THRIFT-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734928#comment-16734928 ]
James E. King III commented on THRIFT-4639: ------------------------------------------- No thrift implementation should depend on sequence numbers for correct behavior at this time. Sequence numbers are necessary when you begin to process multiple outstanding requests from the same client instance which none of the language implementations do (otherwise that client would not know how to match responses to requests). Is there a language implementation that depends on sequence IDs? It sounds like you are saying there is, and that's the real root cause here. Secondarily, I have a backlog item to implement a sequence number validation as part of the cross test, but as you said it will only test the languages that are in the cross test (which may not be all, but is quite a lot). > Sequence numbering for multiplexed protocol broken > -------------------------------------------------- > > Key: THRIFT-4639 > URL: https://issues.apache.org/jira/browse/THRIFT-4639 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Affects Versions: 0.11.0, 0.12.0 > Reporter: PH Lundblom > Priority: Critical > Time Spent: 10m > Remaining Estimate: 0h > > Handling of client sequence numbering for multiplexed protocol is broken. > Current implementation uses client internal variable "seqid" which should be > "_seqid" > -- This message was sent by Atlassian JIRA (v7.6.3#76005)