[ 
https://issues.apache.org/jira/browse/THRIFT-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741335#comment-16741335
 ] 

Christoph Herold commented on THRIFT-3587:
------------------------------------------

Hi [~jensg],

wow, a three year old ticket. Sorry, I don't really remember if we actually 
created a manual patch for this. I'll have to check it on my business machine 
on Tuesday. But, from what I do remember, I think I estimated the 0,5h because, 
as I wrote in the ticket description, the code from TSocket can be moved to 
TTLSSocket as is. It's just adding the timeout to the "open" call.

Anyways, I'll check on Tuesday to see, if we already patched this ourselves, or 
if we decided to live with the current behavior. If we do have a patch, I 
should be able to supply it to you. If not, I'll let you know some more details 
on what I would do.

Cheers,
Christoph

> C# TTLSSocket does not use timeout for opening the socket
> ---------------------------------------------------------
>
>                 Key: THRIFT-3587
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3587
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library
>    Affects Versions: 0.9.3
>            Reporter: Christoph Herold
>            Assignee: Jens Geyer
>            Priority: Minor
>              Labels: C#, TTLSSocket
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The {{TSocket}} class checks for a defined timeout when opening the socket 
> connection and uses a ConnectHelper to perform the {{socket.Open()}} call 
> with the defined timeout. The {{TTLSSocket}} class does not show this 
> behavior. It simply calls {{Open}} without using timeout functionality. The 
> code from {{TSocket}} can probably be reused as is in the {{TTLSSocket}} 
> class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to