Hi Adam, Definitely create an issue in Jira and submit a PR. Things in contrib/ are in there either due to licensing or due to inactivity/inaction to maintain. The latter can be solved with more active development.
- Jim On Tue, Jan 15, 2019 at 5:18 PM Adam Marcionek < amarcio...@seven10storage.com> wrote: > I'm wondering if anyone uses the thrift maven plugin with any success on > Linux? A couple years ago, we created an alternate version which did have > success. It modified the Thrift.compile() function to put /usr/local/lib as > the LD_LIBRARY_PATH so that it could find the thrift install. Would this > be the best way to accomplish this? If not, any suggestions? > > If so, we're happy to submit an issue and PR. Here is the commit that > fixes it (its forked from the original repo, but we'll redo it in the new > place.) > https://github.com/seven10builder/maven-thrift-plugin/commit/ff83d369866a203ee8c5e0a6cc9d65db2b8199f3 > But I have a couple questions: > > > 1. Should I create an issue first in JIRA? > 2. Is it OK that we added new dependencies to get this to work, > specifically the commons exec classes? > > Thanks for any help, > > Adam Marcionek >
