[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791902#comment-16791902 ]
Christopher Tubbs commented on THRIFT-4506: ------------------------------------------- Thanks, [~jking3]! FWIW, I did try to look at, and offer my (non-binding) +1 to the release candidate during the vote, but was unable to do so, because, although I'm subscribed to the dev@ list, the vote did not occur on that list. Please ensure future votes occur on the dev@ list. A public vote on the dev@ list ensures that: # you've created a public record for the vote, # you allow participation/evaluation from your wider user audience (more diversity in evaluators improves quality), and # you provide more entry points for potential future committers/PMC members to earn merit through participation. > [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in > release builds > ------------------------------------------------------------------------------------------ > > Key: THRIFT-4506 > URL: https://issues.apache.org/jira/browse/THRIFT-4506 > Project: Thrift > Issue Type: Bug > Components: Java - Library > Affects Versions: 0.5 > Reporter: James E. King III > Assignee: James E. King III > Priority: Minor > Labels: SASL, security > Fix For: 0.9.3.1, 0.12.0 > > > There is an assertion in the SASL transport for Java that will only be > processed in debug builds, at > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslTransport.java#L298. > The preceeding while loop can be changed to guarantee this assertion in all > builds. > https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-1320 -- This message was sent by Atlassian JIRA (v7.6.3#76005)