[ https://issues.apache.org/jira/browse/THRIFT-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792435#comment-16792435 ]
Jens Geyer commented on THRIFT-4821: ------------------------------------ We accept pull requests :-) > Normalize TServerSocketTransport constructors in netstd > ------------------------------------------------------- > > Key: THRIFT-4821 > URL: https://issues.apache.org/jira/browse/THRIFT-4821 > Project: Thrift > Issue Type: Improvement > Components: netstd - Library > Affects Versions: 0.12.0 > Reporter: Kyle Smith > Assignee: Jens Geyer > Priority: Minor > > Right now you are not able to utilize the built-in buffered or framed > transport features of the current TServerSocketTransport class if you need to > pass in your own TcpListener. This could be resolved by creating just two > constructors using default values to replace the current six. > {{{color:#569cd6}public{color} > TServerSocketTransport({color:#4ec9b0}TcpListener{color} listener, > {color:#569cd6}int{color} clientTimeout {color:#b4b4b4}={color} > {color:#b5cea8}0{color}, {color:#569cd6}bool{color} useBufferedSockets > {color:#b4b4b4}={color} {color:#569cd6}false{color}, > {color:#569cd6}bool{color} useFramedTransport {color:#b4b4b4}={color} > {color:#569cd6}false{color}) }}{{{color:#569cd6}public{color} > TServerSocketTransport({color:#569cd6}int{color} port, > {color:#569cd6}int{color} clientTimeout {color:#b4b4b4}={color} > {color:#b5cea8}0{color}, {color:#569cd6}bool{color} useBufferedSockets > {color:#b4b4b4}={color} {color:#569cd6}false{color}, > {color:#569cd6}bool{color} useFramedTransport {color:#b4b4b4}={color} > {color:#569cd6}false{color}) }} -- This message was sent by Atlassian JIRA (v7.6.3#76005)