[ 
https://issues.apache.org/jira/browse/THRIFT-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-4816.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 0.13.0

Committed

> JSONTransports Context.WriteAsync/ReadAsync are badly named
> -----------------------------------------------------------
>
>                 Key: THRIFT-4816
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4816
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.13.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> It's hard to tell what Context.WriteAsync() does in the following example 
> unless one looks at the implementations.
> {code}
> private async Task WriteJsonObjectStartAsync(CancellationToken 
> cancellationToken)
> {
>         await Context.WriteAsync(cancellationToken);
>         await Trans.WriteAsync(TJSONProtocolConstants.LeftBrace, 
> cancellationToken);
>         PushContext(new JSONPairContext(this));
> }
>  {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to