[ 
https://issues.apache.org/jira/browse/THRIFT-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King III updated THRIFT-4846:
--------------------------------------
    Component/s: C++ - Compiler

> C++ generator should topologically sort struct definitions and error on cycles
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-4846
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4846
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Major
>         Attachments: thrift-4846.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> C++ (and maybe other languages?) treat Thrift struct-typed fields as plain 
> struct members of the containing struct. Currently, the generator outputs the 
> types in the same order as they're defined in the underlying Thrift field, 
> which means that a file like:
> {code}
> struct A {
>   1: B foo;
> }
> struct B {
> }
> {code}
> will generate C++ code that fails to compile.
> We should topologically-sort the structs before outputting the definitions so 
> that the generated code compiles correctly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to