[
https://issues.apache.org/jira/browse/THRIFT-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun updated THRIFT-4942:
--------------------------------
Labels: Breaking-Change newbie pull-request-available (was: newbie
pull-request-available)
> Set PHP struct generated field values as private with getters and setters
> -------------------------------------------------------------------------
>
> Key: THRIFT-4942
> URL: https://issues.apache.org/jira/browse/THRIFT-4942
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
> Affects Versions: 0.12.0
> Environment: I'm using Ubuntu 18.04, applies to all platforms
> Reporter: Dedipyaman Das
> Priority: Major
> Labels: Breaking-Change, newbie, pull-request-available
> Fix For: 0.13.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The PHP autogenerated code currently keeps the struct derived class
> attributes public, and they have to be accessed like: $class->field.
> The java version keeps them private instead and uses getters and setters to
> access and mutate the data.
> A similar approach would be a better choice for most oop based php coding
> standards.
> I've created a working patch, so if I get approval I will create a Pull
> request for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
