[
https://issues.apache.org/jira/browse/THRIFT-4984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958235#comment-16958235
]
Duru Can Celasun commented on THRIFT-4984:
------------------------------------------
> Also can someone provide more context as of why do we treat EOF errors as
> normal there?
I imagine it's because there is nothing the user can do with it. Technically,
we could "return p.AcceptLoop()"
[here|https://github.com/apache/thrift/blob/v0.13.0/lib/go/thrift/simple_server.go#L191]
but what would the user do with it? After an EOF, there is nothing more to be
read from the connection.
> Scary and spammy "error processing request: EOF" logs from TSimpleServer
> ------------------------------------------------------------------------
>
> Key: THRIFT-4984
> URL: https://issues.apache.org/jira/browse/THRIFT-4984
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.13.0
> Reporter: Yuxuan Wang
> Priority: Minor
> Fix For: 0.14.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After upgraded our code to 0.13.0, we noticed a lot of the logs in stderr:
> {code}
> 2019/10/22 22:04:52 error processing request: EOF
> {code}
> I think they are generated by this line
> https://github.com/apache/thrift/blob/v0.13.0/lib/go/thrift/simple_server.go#L167,
> which means EOF is an error returned by processRequests function.
> In that function we actually treat some EOF errors as non-errors
> ([example|https://github.com/apache/thrift/blob/v0.13.0/lib/go/thrift/simple_server.go#L266]),
> so I think it's just that we missed some cases and didn't treat all harmless
> EOF errors as non-errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
