[ 
https://issues.apache.org/jira/browse/THRIFT-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979637#comment-16979637
 ] 

Duru Can Celasun commented on THRIFT-5019:
------------------------------------------

Not sure about other languages but for Go specifically, having multiple IDL 
files within the same namespace always worked fine as long as those files were 
not included into another namespace.

More generally, since [the spec doesn't mention such 
limitations|https://github.com/apache/thrift/blob/master/doc/specs/idl.md#thrift-include],
 it's worth fixing this in other generators as well.

> Multiple import same namespace for go included files
> ----------------------------------------------------
>
>                 Key: THRIFT-5019
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5019
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>    Affects Versions: 0.12.0, 0.13.0
>            Reporter: Andrey Petko
>            Assignee: Duru Can Celasun
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When I include two files with same namespace for go language:
> {code:java}
> include "common/Exceptions.thrift"
> include "common/Typedefs.thrift"{code}
> And generate it for golang in result in import I have import of this 
> namespace twice:
> {code:java}
> import(
>    "bytes"
>    "context"
>    "reflect"
>    "fmt"
>    "github.com/apache/thrift/lib/go/thrift"
>    "my_namespace"
>    "my_namespace"
> )
> {code}
> And when I try to use I have an error because of this:
> "'my_namespace' redeclared as imported package name"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to