[ 
https://issues.apache.org/jira/browse/THRIFT-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049631#comment-17049631
 ] 

Jano Svitok edited comment on THRIFT-5084 at 3/2/20 9:24 PM:
-------------------------------------------------------------

This patch (PR2002) changed Package.swift to require swift tools 5.1, so the 
docker image can't run swift tests.

See log 
[https://travis-ci.org/apache/thrift/jobs/646781510?utm_medium=notification&utm_source=github_status]
 :
 /thrift/src/lib/swift: error: package at '/thrift/src/lib/swift' requires a 
minimum Swift tools version of 5.1.0 (currently 4.2.0)

 

EDIT: it seems that simply changing version in the first line to 4.2.0 makes 
swift happy.


was (Author: janosvitok):
This patch (PR2002) changed Package.swift to require swift tools 5.1, so the 
docker image can't run swift tests.

See log 
[https://travis-ci.org/apache/thrift/jobs/646781510?utm_medium=notification&utm_source=github_status]
 :
/thrift/src/lib/swift: error: package at '/thrift/src/lib/swift' requires a 
minimum Swift tools version of 5.1.0 (currently 4.2.0)

> Swift: Server-side support for Multiplexing Services
> ----------------------------------------------------
>
>                 Key: THRIFT-5084
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5084
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Swift - Library
>    Affects Versions: 0.13.0
>            Reporter: Alexander Edge
>            Assignee: Alexander Edge
>            Priority: Blocker
>              Labels: multiplex
>             Fix For: 0.14.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The Swift library features {{TMultiplexedProtocol}} but not 
> {{TMultiplexedProcessor}}, which is required for use server-side.
> I've added {{TMultiplexedProcessor}}, following the same patterns as the 
> other language libraries. -I've marked this issue as _Breaking-Change_ since 
> it removes the {{associatedType}} from the {{TProcessor}} protocol-. I've 
> removed the {{associatedType}} from {{TProcessor}} otherwise it makes it 
> impossible for {{TMultiplexedProcessor}} to implement {{TProcessor}}. By 
> definition it should support processors of multiple services, not a single 
> service.
> I've added tests which require a change to {{Package.swift}} to run using 
> {{swift test}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to