[ 
https://issues.apache.org/jira/browse/THRIFT-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055878#comment-17055878
 ] 

Jano Svitok commented on THRIFT-5087:
-------------------------------------

This is the cause of this issue: https://github.com/apache/thrift/pull/1995
The condition is OK. I read it as "If /usr/bin/python IS 2.x then search for 
python3 et al. If /usr/bin/python is 3.x, there's no need to search for another 
python3". So, if /usr/bin/python =$PYTHON is 3.x, call $PYTHON everywhere 
python3 is required.

This is a bit unfortunate, because it's not clear where python 3 is needed and 
where 2 may work/be required.

Christopher wrote that --with-py3 does not work, without any details. I may 
only guess that is might be related to the fact that python2 and python3 are 
not distinct enough.

For now, I propose to revert PR 1995, and fix Christopher's bug afterwards.

> test/test.py fails with "AssertionError: Python 3.3 or later is required for 
> proper operation."
> -----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-5087
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5087
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>            Reporter: Jens Geyer
>            Priority: Blocker
>              Labels: ci-failure
>
> {code}
> /usr/bin/python test/test.py --retry-count 5 --features .* 
> --skip-known-failures --server 
> cpp,c_glib,cl,d,java,csharp,py,,rb,hs,perl,php,go,nodejs,dart,erl,lua,rs,netstd,nodets
> Traceback (most recent call last):
>   File "test/test.py", line 45, in <module>
>     assert (cur_version >= req_version), "Python 3.3 or later is required for 
> proper operation."
> AssertionError: Python 3.3 or later is required for proper operation.
> Makefile:1129: recipe for target 'crossfeature' failed
> make: *** [crossfeature] Error 1
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to