[ https://issues.apache.org/jira/browse/THRIFT-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074161#comment-17074161 ]
Jens Geyer commented on THRIFT-3356: ------------------------------------ >From the pull request: {quote} Handle undefined `captureStackTrace` function when using thrift in a browser (Firefox) environment. For more information see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error {quote} > TypeError: 'undefined' is not a function (evaluating > 'Error.captureStackTrace(this, this.constructor)') > ------------------------------------------------------------------------------------------------------- > > Key: THRIFT-3356 > URL: https://issues.apache.org/jira/browse/THRIFT-3356 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Reporter: Jens Geyer > Priority: Major > Labels: test-suite > Time Spent: 10m > Remaining Estimate: 0h > > {{make check}} fails at NodeJS with this error (multiple occurences): > {code} > ok 59 testException: no callback error > ok 60 testException: no response > TypeError: 'undefined' is not a function (evaluating > 'Error.captureStackTrace(this, this.constructor)') > http://localhost:3000/tests-bundle.js:2566 > TypeError: 'undefined' is not a function (evaluating > 'Error.captureStackTrace(this, this.constructor)') > http://localhost:3000/tests-bundle.js:2566 in InputBufferUnderrunError > http://localhost:3000/tests-bundle.js:2955 > http://localhost:3000/tests-bundle.js:4845 > http://localhost:3000/tests-bundle.js:22525 > :1 > http://localhost:3000/tests-bundle.js:580 > http://localhost:3000/tests-bundle.js:4837 > http://localhost:3000/tests-bundle.js:4809 > ok 61 checkOffByOne: no callback error > ok 62 should be equal > TypeError: 'undefined' is not a function (evaluating > 'Error.captureStackTrace(this, this.constructor)') > http://localhost:3000/tests-bundle.js:2566 > TypeError: 'undefined' is not a function (evaluating > 'Error.captureStackTrace(this, this.constructor)') > http://localhost:3000/tests-bundle.js:2566 in InputBufferUnderrunError > http://localhost:3000/tests-bundle.js:2955 > http://localhost:3000/tests-bundle.js:4845 > http://localhost:3000/tests-bundle.js:22525 > :1 > http://localhost:3000/tests-bundle.js:580 > http://localhost:3000/tests-bundle.js:4837 > http://localhost:3000/tests-bundle.js:4809 > Browser: Server successfully tested! > 1..62 > # tests 62 > # pass 62 > # ok > npm ERR! Test failed. See above for more details. > Makefile:604: recipe for target 'check' failed > make[2]: *** [check] Error 1 > make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/nodejs' > Makefile:539: recipe for target 'check-recursive' failed > make[1]: *** [check-recursive] Error 1 > make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib' > Makefile:609: recipe for target 'check-recursive' failed > make: *** [check-recursive] Error 1 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)