[ 
https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079981#comment-17079981
 ] 

Jens Geyer edited comment on THRIFT-5173 at 4/9/20, 8:21 PM:
-------------------------------------------------------------

When you ask "why" then that is the exact reason why I ask to verify this. I 
don't say it does per se, I just say you should test because it may happen. If 
we find no difference worth mentioning that's all we want.


was (Author: jensg):
When you ask "why" then that is the exact reason I want you to verify this. I 
don't say it does per se, I just say you should test because it is possible.

> Thrift C# (netstd) code generator: make method virtual for mocking
> ------------------------------------------------------------------
>
>                 Key: THRIFT-5173
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5173
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>    Affects Versions: 0.13.0
>            Reporter: Eric Bléher
>            Priority: Major
>
> Thrift compiler generates C# clients where methods cannot be mocked because 
> they are not defined as virtual.
> Adding virtual allow the usage of Moq and thus I can have proper unit tests 
> of my own class implementations consuming theses generated clients.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to