[
https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083983#comment-17083983
]
Jens Geyer commented on THRIFT-5173:
------------------------------------
I think that would be overkill.
> Thrift C# (netstd) code generator: make method virtual for mocking
> ------------------------------------------------------------------
>
> Key: THRIFT-5173
> URL: https://issues.apache.org/jira/browse/THRIFT-5173
> Project: Thrift
> Issue Type: Improvement
> Components: netstd - Compiler
> Affects Versions: 0.13.0
> Reporter: Eric Bléher
> Priority: Major
>
> Thrift compiler generates C# clients where methods cannot be mocked because
> they are not defined as virtual.
> Adding virtual allow the usage of Moq and thus I can have proper unit tests
> of my own class implementations consuming theses generated clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
