emmenlau opened a new pull request #2116: URL: https://github.com/apache/thrift/pull/2116
This PR adds wrapping to the TZlibTransportFactory. This is very helpful so that servers can create their "normal" transport factory like before, then wrap it into a TZlibTransportFactory. This makes the server code very consistent with the client code. It has also been a frequent request, and the lack of this wrapping was explicitly commented in `TestClient.cpp`. I've used the wrapped TZlibTransportFactory with a large number of transports and protocols on multiple platforms successfully. Also, a similar wrapper was added recently for Go in https://issues.apache.org/jira/browse/THRIFT-4346. - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
