emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618958494
Dammit, you are right! Thanks.
Slightly off-topic, I think the comments in the Dockerfile should really be
changed. I've had good experience with adding comments in chains of ` && ` via
echo. So instead of
```
# dotnet (core)
curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor >
/etc/apt/trusted.gpg.d/microsoft.gpg && \
echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-xenial-prod xenial main"
> \
/etc/apt/sources.list.d/dotnetdev.list && \
# node.js
curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key
add - && \
echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee
/etc/apt/sources.list.d/nodesource.list && \
# ruby 2.4
apt-add-repository ppa:brightbox/ruby-ng
```
I personally would highly prefer
```
echo "Installing dotnet (core)" && \
curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor >
/etc/apt/trusted.gpg.d/microsoft.gpg && \
echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-xenial-prod xenial main"
> \
/etc/apt/sources.list.d/dotnetdev.list && \
echo "Installing node.js" && \
curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key
add - && \
echo "deb https://deb.nodesource.com/node_10.x xenial main" | tee
/etc/apt/sources.list.d/nodesource.list && \
echo "Installing ruby 2.4" && \
apt-add-repository ppa:brightbox/ruby-ng
```
This does some part of documentation, remains visible in the execution, and
most importantly it does not break the chain of ` && `-connections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
