[ https://issues.apache.org/jira/browse/THRIFT-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105379#comment-17105379 ]
Mario Emmenlauer commented on THRIFT-5186: ------------------------------------------ Since updating from master commit 7c4bdf9 to 55680af I get errors in dockerized tests on Ubuntu 18.04 vanilla. I've tried to isolate the problem, and I'm under the impression that this PR is at fault (commit 9b9567b "THRIFT-5186: Don't pass AI_ADDRCONFIG to getaddrinfo()"). When reverting this commit everything works again as expected. With the commit, the errors I get are in multiple tests, all of the form: {code} 409: Thrift: Tue May 12 11:34:13 2020 TServerSocket::listen() Could not bind to 0 409: unknown location(0): fatal error: in "TServerSocketTest/test_bind_to_address": apache::thrift::transport::TTransportException: Could not bind: Cannot assign requested address 409: /home/bdaci01/builds/37284781/0/BioDataAnalysis/thrift/lib/cpp/test/TServerSocketTest.cpp(35): last checkpoint: "test_bind_to_address" test entry 409: 409: *** 1 failure is detected in the test module "thrift" 409: 409/440 Test #409: UnitTests ..................................***Failed 0.62 sec {code} The following tests FAILED: * 409 - UnitTests (Failed) * 410 - TInterruptTest (Failed) * 411 - TServerIntegrationTest (Failed) * 431 - SecurityTest (Timeout) * 432 - SecurityFromBufferTest (Timeout) > AI_ADDRCONFIG: Thrift libraries crash with localhost-only network. > ------------------------------------------------------------------ > > Key: THRIFT-5186 > URL: https://issues.apache.org/jira/browse/THRIFT-5186 > Project: Thrift > Issue Type: Bug > Components: C++ - Library, Delphi - Library, Python - Library > Affects Versions: 0.13.0 > Environment: Red Hat Enterprise Linux 8.0 > Reporter: Max > Assignee: Max > Priority: Major > Labels: getaddrinfo, localhost, sockets > Fix For: 0.14.0 > > Attachments: > 0001-THRIFT-5186-Dont-pass-AI_ADDRCONFIG-to-getaddrinfo.patch > > Time Spent: 10m > Remaining Estimate: 0h > > THRIFT-2539 has been reported, and fixed — but for win32 only, for no > apparent reason. The exact same problem reproduces on POSIX. > Namely, when no network interfaces besides {{lo}} (the 127.0.0.1 loopback > interface) are up, C++ and Python apps linked with Thrift-generated code, > both clients and servers — *crash by throwing an exception*. Even when the > intention is exactly to run them on localhost only. > This happens because Thrift library code for TSocket, TServerSocket, > TNonblockingServerSocket calls > [{{getaddrinfo()}}|http://man7.org/linux/man-pages/man3/getaddrinfo.3.html] > to resolve target hostname to connect to/listen on, into concrete IP address > (v4 or v6, whichever the system is configured for). To that call, it *passes > the {{AI_ADDRCONFIG}} hint* which effectively turns a localhost-only > situation into: > {quote}{{Could not resolve host for client socket.}} > {quote} > and into this (server-side): > {code:java} > гру 23 13:52:13 localhost.localdomain systemd[1]: db_cache.service: Main > process exited, code=dumped, status=6/ABRT > гру 23 13:52:13 localhost.localdomain systemd[1]: db_cache.service: Failed > with result 'core-dump'. > гру 23 13:52:17 localhost.localdomain db_cache[12912]: Thrift: Mon Dec 23 > 13:52:15 2019 TSocket::open() getaddrinfo() <Host: 127.0.0.1 Port: > 1302>Address family for hostname not supported > гру 23 13:52:17 localhost.localdomain db_cache[12912]: Thrift: Mon Dec 23 > 13:52:15 2019 TSocket::open() getaddrinfo() <Host: 127.0.0.1 Port: > 8345>Address family for hostname not supported > гру 23 13:52:17 localhost.localdomain db_cache[12912]: Thrift: Mon Dec 23 > 13:52:15 2019 TNonblocking: using dedicated listener thread, io threads: 16 > гру 23 13:52:17 localhost.localdomain db_cache[12912]: Thrift: Mon Dec 23 > 13:52:15 2019 getaddrinfo -9: Address family for hostname not supported > гру 23 13:52:17 localhost.localdomain db_cache[12912]: terminate called after > throwing an instance of 'apache::thrift::transport::TTransportException' > гру 23 13:52:17 localhost.localdomain db_cache[12912]: what(): Could not > resolve host for server socket. > {code} > I fail to understand the original reason to pass that {{AI_ADDRCONFIG}} hint. > It shouldn't be there as I see it. > Further, since Thrift 0.9.2, windows builds of thrift apps don't pass that > hint anymore (see THRIFT-2539), and it seems to be okay. > For comprehension, I'm attaching a sample patch to remove {{AI_ADDRCONFIG}} > from {{lib/cpp}} and {{lib/py}}. The main change will be landing via GitHub, > per Thrift's contribution process, so please follow there too. -- This message was sent by Atlassian Jira (v8.3.4#803005)