[ 
https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105543#comment-17105543
 ] 

Prashant V commented on THRIFT-5205:
------------------------------------

Thanks, I'm mostly interested in 0.10.0 (which is the last release before the 
context parameter was added which isn't compatible with some libraries)

Running `go get library@revision` works, but it has to be done in the "leaf" 
repository. In our case we have:

100s of repositories depend on libA, which depends on thrift

libA wants to specify that it is only compatible with 0.10.0, but the leaf 
repositories cannot inherit this restriction since it's not a constraint that 
Go modules can follow, and exact version pins aren't inherited. The alternative 
is that every leaf repository needs to specify the exact hash.

> Tag prior releases with "v" prefix for compatibility with go.mod
> ----------------------------------------------------------------
>
>                 Key: THRIFT-5205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5205
>             Project: Thrift
>          Issue Type: Wish
>          Components: Go - Library
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Prashant V
>            Priority: Minor
>
> Thrift 0.13.0 uses the tag "v0.13.0", while prior releases do not have the 
> "v" prefix. Is it possible to add an additional tag "v0.10.0", "v0.11.0", etc 
> for older releases so that Go modules works correctly with them, see 
> [https://github.com/golang/go/issues/32945]
>  
> We have some projects that use older versions and can't update due to the 
> breaking changes where ctx was added as a parameter, so need to use old 
> versions, but would still like to use go.mod.
>  
> Adding additional tags (the old ones should still be valid) would help 
> unblock usage of Go modules.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to