[
https://issues.apache.org/jira/browse/THRIFT-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116109#comment-17116109
]
Jonathan edited comment on THRIFT-5039 at 5/25/20, 4:04 PM:
------------------------------------------------------------
[~emmenlau] Sorry for the late reply.
I installed it to take a look. Indeed it does seem to solve the one issue here,
which is that the Node.js runtime wasn't bundled. I am sure the other issues
you fixed are good fixes to make too, but I can't verify them without knowing
what they are.
I also don't know why anything else should need to be included for this one
very critical issue with the npm package being completely broken on its latest
version, when it would only take a republish of 0.13.0 from the proper
directory of the repo. The only issue here is that the Node.js runtime simply
was not published at all to 0.13.0 on npm, and the fix is very simple, it just
needs publisher access to the npm package.
It's easy to see the correct version of the package working fine if you just do
{{npm add git://github.com/apache/thrift.git#v0.13.0}} instead of {{npm add
thrift @0.13.0}}. And this needs to be addressed for 0.13.0 specifically, for
anyone depending on that version being available for client/server version
matching.
How do we reach someone with publisher access and the time to address this?
was (Author: jrajav):
[~emmenlau] Sorry for the late reply.
I installed it to take a look. Indeed it does seem to solve the one issue here,
which is that the browser runtime wasn't bundled. I am sure the other issues
you fixed are good fixes to make too, but I can't verify them without knowing
what they are.
I also don't know why anything else should need to be included for this one
very critical issue with the npm package being completely broken on its latest
version, when it would only take a republish of 0.13.0 from the proper
directory of the repo. The only issue here is that the Node.js runtime simply
was not published at all to 0.13.0 on npm, and the fix is very simple, it just
needs publisher access to the npm package.
It's easy to see the correct version of the package working fine if you just do
{{npm add git://github.com/apache/thrift.git#v0.13.0}} instead of {{npm add
thrift @0.13.0}}. And this needs to be addressed for 0.13.0 specifically, for
anyone depending on that version being available for client/server version
matching.
How do we reach someone with publisher access and the time to address this?
> thrift npm package should be published from root folder
> -------------------------------------------------------
>
> Key: THRIFT-5039
> URL: https://issues.apache.org/jira/browse/THRIFT-5039
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.13.0
> Reporter: Soner Okur
> Assignee: James E. King III
> Priority: Critical
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Thrift npm package was published from js folder. Therefore, we can't build
> our software because lack of nodejs library. Can you re-publish the package ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
