emmenlau opened a new pull request #2165:
URL: https://github.com/apache/thrift/pull/2165
This PR adds a very minor change: it deprecates handling of WinXP and
Windows Server 2003 in `lib/cpp/src/thrift/windows/WinFcntl.{h,cpp}`. This
simplifies code maintenance. I'm under the impression that support for WinXP
should be dropped now.
Does this require an explicit mention in a change log? I would assume that
WinXP and Server 2003 are not officially supported since a while now?
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
