pprice opened a new pull request #1855:
URL: https://github.com/apache/thrift/pull/1855
- [js] Missing class name for generated services and processors; this makes
instrumentation of outbound calls (e.g. which service are we calling in to)
difficult. Generating a class name for es6 enables x.constructor.name to get
generated name.
- [js] Fix case where services have a method with an argument named
"params", generated code generates an identifier in the "send_XXX" body named
"params" which conflicts with the argument. Ensure the identifier in the body
is uniquely named.
- [js] Ensure that derived services (extends XYZService) correctly call
super() in their constructor.
- [ts] Ensure that derived services (extends XYZSerice) correctly specify
the base class Client and Processor name
- [js] Ensure that derived service clients do not redefine private fields
(output, pClass, _seqId, _reqs) and call super();
- [ts] Ensure derived service clients and processors do not redefine
private fields in declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
