fishy opened a new pull request #2174: URL: https://github.com/apache/thrift/pull/2174
Client: go While debugging the issue in THRIFT-5214, I original thought that was a bug in TFramedTransport implementation, so I took some time scrutinize the TFramedTransport code. Although in the end there's no bug, the current implementation of TFramedTransport, especially in the Read function, has some weird handling while at frame boundary, which is both error-prone and hard to follow (I did found and fixed one bug there in https://github.com/apache/thrift/pull/1810 before). The new implementation reads the whole frame into a buffer, which would use slightly more memory, but it follows the pattern of TFramedTransport implementation of other languages (e.g. Java), and also the pattern we handle frame in THeaderTransport. It also reduced the complexity and weirdness of the frame boundary handling in Read implementation. This rewrite also removes the print call from library code. <!-- Explain the changes in the pull request below: --> <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org