[
https://issues.apache.org/jira/browse/THRIFT-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang resolved THRIFT-5257.
---------------------------------
Fix Version/s: 0.14.0
Resolution: Fixed
> Go THeader implementation doesn't handle endOfFrame correctly
> -------------------------------------------------------------
>
> Key: THRIFT-5257
> URL: https://issues.apache.org/jira/browse/THRIFT-5257
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.13.0
> Reporter: Yuxuan Wang
> Assignee: Yuxuan Wang
> Priority: Major
> Fix For: 0.14.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In the current implementation, we only call endOfFrame when we hit EOF when
> reading from the frameReader. The problem is in go stdlib the read action
> finished reading the remaining data from frameReader will not return EOF, the
> next Read will. This caused us in most cases only call endOfFrame at the
> beginning of the next frame, which could cause troubles because we didn't
> read the beginning of the frame properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
