fishy opened a new pull request #2261: URL: https://github.com/apache/thrift/pull/2261
This also comes from the discussion of https://github.com/apache/thrift/pull/1992#issuecomment-705903922. I think TDebugProtocol is a better fit for this feature than creating a new TProtocol implementation. The Dump field is not added to TDebugProtocolFactory because I don't think it makes sense from the factory setup. In vast majority cases users would need direct access to the underlying TMemoryBuffer to make it useful, which is easier this way than an additional TTransportFactory plus TProtocolFactory to make TDebugProtocolFactory way too complex. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
