[
https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223371#comment-17223371
]
shuo li commented on THRIFT-5299:
---------------------------------
[~jensg] I've been reading through all the rust code and also other lang(python
cpp golang)'s, then confirmed this is an issue. Also I issued a bug in
integer-encoding crate, which the author also confirmed the problem. Currently
most of thrift impl is round trip test, which means as long as the encode and
decode use same impl, then the test passed. Which means writing a test case to
confirm this issue more effort.
Anyway, you are the boss, feel free to close this issue if it is not helping.
> rs implementation compact protocol seq_id should not use zigzag encoding.
> -------------------------------------------------------------------------
>
> Key: THRIFT-5299
> URL: https://issues.apache.org/jira/browse/THRIFT-5299
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
> Affects Versions: 0.13.0
> Reporter: shuo li
> Priority: Major
>
> While reviewing code, I discovered a bug in compact protocol.
> The seq_id in message header is decoded with integer-encoding's i32, which
> uses zigzag decode implicitly.
>
>
> EDIT: correct the title and desc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
