emmenlau opened a new pull request #2280: URL: https://github.com/apache/thrift/pull/2280
The current thrift build does not work well with the clang frontend for the Visual Studio compiler (often called "ClangCl" or "clang-cl"). This is because ClangCl identifies to cmake as "MSVC" but also as "clang". ClangCl differs from "normal" clang in a few minor points. The most relevant is that it does not handle the setting `-Wall` too well, because in ClangCl `-Wall` includes a few very obscure warnings like "compatibility with c++98" (which thrift does not have). This leads to hundreds of thousands of warnings, making the build practically unusable. The solution is quite simple: Change the order of compilers in cmake, so MSVC is detected *before* Clang. - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org