[ 
https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245959#comment-17245959
 ] 

Dmitry Shaposhnikov commented on THRIFT-4685:
---------------------------------------------

Now when Go modules are pretty matured, I'd like to raise question about Go 
thrift library versioning again.

It happens that module A depends on modules B, C which require different 
versions of Thrift Go library. Sometimes it really blocks, because Go module 
can't depend on different non-major versions of other module simultaneously.

Just as an example [https://github.com/uber/tchannel-go/issues/781]

Thrift versioning differs from Go modules one. All Thrift releases start with 
v0. and many of them carry breaking changes.

For Go modules major change of API or functions signatures leads to major 
module version change (e.g. v1.0.0 -> v2.0.0). Good news: module can 
simultaneously depend on several major versions of another particular module. 
So it would solve problem in previous example.

Is it possible to migrate to Semantic Versioning for Thrift project?

Btw, from github docs: "We recommend naming tags that fit within semantic 
versioning"

 

> Support the new golang modules (1.11 or later)
> ----------------------------------------------
>
>                 Key: THRIFT-4685
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4685
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>    Affects Versions: 0.12.0
>         Environment: golang 1.11 or later
>            Reporter: James E. King III
>            Assignee: Duru Can Celasun
>            Priority: Minor
>
> Go added new module support in 1.11, see:
> https://github.com/golang/go/wiki/Modules
> We should move towards it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to