[ 
https://issues.apache.org/jira/browse/THRIFT-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273961#comment-17273961
 ] 

Jens Geyer commented on THRIFT-5237:
------------------------------------

After applying a fix I now get these failures on AppVeyor. Travis still pending.

 
408: unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tmemorybuffer_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5181|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5181]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(75): last checkpoint
[5182|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5182]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tpipedtransport_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5183|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5183]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(88): last checkpoint
[5184|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5184]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tsimplefiletransport_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5185|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5185]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(107): last checkpoint
[5186|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5186]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tfiletransport_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5187|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5187]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(121): last checkpoint
[5188|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5188]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tbufferedtransport_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5189|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5189]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(133): last checkpoint
[5190|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5190]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tframedtransport_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5191|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5191]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(143): last checkpoint
[5192|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5192]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tthriftbinaryprotocol_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5193|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5193]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(157): last checkpoint
[5194|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5194]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tthriftcompactprotocol_read_check_exception":
 apache::thrift::transport::TTransportException: MaxMessageSize reached
[5195|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5195]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(184): last checkpoint
[5196|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5196]408:
 unknown location(0): fatal error: in 
"ThriftReadCheckExceptionTest/test_tthriftjsonprotocol_read_check_exception": 
apache::thrift::transport::TTransportException: MaxMessageSize reached
[5197|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5197]408:
 C:\projects\thrift\lib\cpp\test\ThrifttReadCheckTests.cpp(211): last checkpoint
[5198|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5198]408:
 An error message from getaddrinfo on the console is expected:
[5199|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5199]408:
 [C:\projects\thrift\lib\cpp\src\thrift\transport\TFileTransport.cpp,737] [Thu 
Jan 28 08:17:02 2021] ERROR: Read corrupt event. Event size(67305985) greater 
than chunk size (16777216) 
[5200|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5200]408:
 Thrift: Thu Jan 28 08:17:02 2021 TFileTransport: log file corrupted at offset: 0
[5201|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5201]408:
 Thrift: Thu Jan 28 08:17:02 2021 TFileTransport: writerThread() initialization 
: The operation completed successfully.
[5202|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5202]408:
 Thrift: Thu Jan 28 08:17:02 2021 getaddrinfo() -> 11001; Unknown error
[5203|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5203]408:
 
[5204|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5204]408:
 *** 9 failures are detected in the test module "thrift"
[5205|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5205]408/435
 Test #408: UnitTests ........................***Failed    0.50 sec
[5206|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5206]test
 409
[5207|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5207]
        Start 409: TInterruptTest
[5208|https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/37487172/job/2q5v6a0xnev10j1b#L5208]

> Implement MAX_MESSAGE_SIZE and consolidate limits into a TConfiguration class
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-5237
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5237
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C glib - Library, C++ - Library, Java - Library
>            Reporter: Zezeng Wang
>            Assignee: Zezeng Wang
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> This ticket has two related goals:
> a) to implement a new limit for the maximum message size similar to max 
> frames size etc
> b) consolidate and centralize all limits we have (max msg size,. max frame 
> size and max recursion depth) into one place in the code



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to