[ 
https://issues.apache.org/jira/browse/THRIFT-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279147#comment-17279147
 ] 

Mario Emmenlauer commented on THRIFT-5274:
------------------------------------------

I just wanted to add that according to 
https://stackoverflow.com/a/58286924/7200132, it seems that compiling Java code 
as a lower Java version even when featuring a newer JVM should *not* hurt 
performance, but should improve compatibility.

So the PR seems to have a mostly positive effect :-)

> Thrift 0.13.0 does not work with JDK8
> -------------------------------------
>
>                 Key: THRIFT-5274
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5274
>             Project: Thrift
>          Issue Type: Task
>          Components: Java - Library
>            Reporter: Colm O hEigeartaigh
>            Assignee: Christopher Tubbs
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Thrift 0.13.0 does not work with JDK8, as it is compiled with JDK11. Even 
> though the source version is JDK8, incorrect byte code is generated for 
> various ByteBuffer methods, e.g.:
> Exception in thread "TAsyncClientManager#SelectorThread 22" 
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.rewind()Ljava/nio/ByteBuffer;
> The fix is suggested in this blog post: 
> [https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/]
> We can add the release flag for 1.8 (-release=8).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to