[ 
https://issues.apache.org/jira/browse/THRIFT-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jihoon Seo updated THRIFT-5348:
-------------------------------
    Description: 
In 
[debian/copyright|https://github.com/apache/thrift/blob/master/debian/copyright],

 

1. The file says

??Portions of the following files are licensed under the MIT License:??

??lib/erl/src/Makefile.am??

 

but there is no Makefile.am in 
[lib/erl/src/|https://github.com/apache/thrift/tree/master/lib/erl/src].

 

Instead, there exists 
[lib/erl/Makefile.am|https://github.com/apache/thrift/blob/master/lib/erl/Makefile.am].

 

2. These paths need to be checked and updated.

 

?? compiler/cpp/Makefile.am??
 ?? compiler/cpp/src/generate/t_cpp_generator.cc??
 ?? compiler/cpp/src/generate/t_netstd_generator.cc??
 ?? compiler/cpp/src/generate/t_erl_generator.cc??
 ?? compiler/cpp/src/generate/t_hs_generator.cc??
 ?? compiler/cpp/src/generate/t_java_generator.cc??
 ?? compiler/cpp/src/generate/t_ocaml_generator.cc??
 ?? compiler/cpp/src/generate/t_perl_generator.cc??
 ?? compiler/cpp/src/generate/t_php_generator.cc??
 ?? compiler/cpp/src/generate/t_py_generator.cc??
 ?? compiler/cpp/src/generate/t_rb_generator.cc??
 ?? compiler/cpp/src/generate/t_st_generator.cc??
 ?? compiler/cpp/src/generate/t_xsd_generator.cc??
 ?? compiler/cpp/src/main.cc??
 ?? compiler/cpp/src/parse/t_field.h??
 ?? compiler/cpp/src/parse/t_program.h??
 ?? compiler/cpp/src/platform.h??
 ?? compiler/cpp/src/thriftl.ll??
 ?? compiler/cpp/src/thrifty.yy??
 ?? lib/netstd/src/Protocol/TBinaryProtocol.cs??
 ?? lib/netstd/src/Protocol/TField.cs??
 ?? lib/netstd/src/Protocol/TList.cs??
 ?? lib/netstd/src/Protocol/TMap.cs??
 ?? lib/netstd/src/Protocol/TMessage.cs??
 ?? lib/netstd/src/Protocol/TMessageType.cs??
 ?? lib/netstd/src/Protocol/TProtocol.cs??
 ?? lib/netstd/src/Protocol/TProtocolException.cs??
 ?? lib/netstd/src/Protocol/TProtocolFactory.cs??
 ?? lib/netstd/src/Protocol/TProtocolUtil.cs??
 ?? lib/netstd/src/Protocol/TSet.cs??
 ?? lib/netstd/src/Protocol/TStruct.cs??
 ?? lib/netstd/src/Protocol/TType.cs??
 ?? lib/netstd/src/Server/TServer.cs??
 ?? lib/netstd/src/Server/TSimpleServer.cs??
 ?? lib/netstd/src/Server/TThreadPoolServer.cs??
 ?? lib/netstd/src/TApplicationException.cs??
 ?? lib/netstd/src/Thrift.csproj??
 ?? lib/netstd/src/Thrift.sln??
 ?? lib/netstd/src/TProcessor.cs??
 ?? lib/netstd/src/Transport/TServerSocket.cs??
 ?? lib/netstd/src/Transport/TServerTransport.cs??
 ?? lib/netstd/src/Transport/TSocket.cs??
 ?? lib/netstd/src/Transport/TStreamTransport.cs??
 ?? lib/netstd/src/Transport/TTransport.cs??
 ?? lib/netstd/src/Transport/TTransportException.cs??
 ?? lib/netstd/src/Transport/TTransportFactory.cs??
 ?? lib/netstd/ThriftMSBuildTask/Properties/AssemblyInfo.cs??
 ?? lib/netstd/ThriftMSBuildTask/ThriftBuild.cs??
 ?? lib/netstd/ThriftMSBuildTask/ThriftMSBuildTask.csproj??
 ?? lib/rb/lib/thrift.rb??
 ?? lib/st/README??
 ?? lib/st/thrift.st??
 ?? test/OptionalRequiredTest.cpp??
 ?? test/OptionalRequiredTest.thrift??
 ?? test/ThriftTest.thrift??

 

3. The file says

 

??For the compiler/cpp/src/md5.[ch] components:??

 

but there is no md5-related file in 
[compiler/cpp/src/|https://github.com/apache/thrift/tree/master/compiler/cpp/src].

 

4. The file says

??For the lib/rb/setup.rb: Copyright (c) 2000-2005 Minero Aoki,??

but there is no setup.rb file in 
[lib/rb/|https://github.com/apache/thrift/tree/master/lib/rb].

 

5. The file says

??lib/ocaml/OCamlMakefile and lib/ocaml/README-OCamlMakefile components:??

but both files do not exist.

 

6. The file says

??(see doc/lgpl-2.1.txt for the full terms of this license)??

but the correct path is 
[doc/licenses/lgpl-2.1.txt|https://github.com/apache/thrift/blob/master/doc/licenses/lgpl-2.1.txt].

 

??Please see doc/otp-base-license.txt for the full terms of this license.??

but the correct path is 
[doc/licenses/otp-base-license.txt|https://github.com/apache/thrift/blob/master/doc/licenses/otp-base-license.txt].

 

??The following files contain some portions of code contributed under??
 ??the Thrift Software License (see doc/old-thrift-license.txt), and 
relicensed??
 ??under the Apache 2.0 License:??

but cannot find old-thrift-license.txt file in doc/ or doc/licenses.

 

 

 

  was:
In 
[debian/copyright|https://github.com/apache/thrift/blob/master/debian/copyright],

 

1. The file says

??Portions of the following files are licensed under the MIT License:??

??lib/erl/src/Makefile.am??

 

but there is no Makefile.am in 
[lib/erl/src/|[https://github.com/apache/thrift/tree/master/lib/erl/src].]

 

Instead, there exists 
[lib/erl/Makefile.am|[https://github.com/apache/thrift/blob/master/lib/erl/Makefile.am].]

 

2. These paths need to be checked and updated.

 

?? compiler/cpp/Makefile.am??
?? compiler/cpp/src/generate/t_cpp_generator.cc??
?? compiler/cpp/src/generate/t_netstd_generator.cc??
?? compiler/cpp/src/generate/t_erl_generator.cc??
?? compiler/cpp/src/generate/t_hs_generator.cc??
?? compiler/cpp/src/generate/t_java_generator.cc??
?? compiler/cpp/src/generate/t_ocaml_generator.cc??
?? compiler/cpp/src/generate/t_perl_generator.cc??
?? compiler/cpp/src/generate/t_php_generator.cc??
?? compiler/cpp/src/generate/t_py_generator.cc??
?? compiler/cpp/src/generate/t_rb_generator.cc??
?? compiler/cpp/src/generate/t_st_generator.cc??
?? compiler/cpp/src/generate/t_xsd_generator.cc??
?? compiler/cpp/src/main.cc??
?? compiler/cpp/src/parse/t_field.h??
?? compiler/cpp/src/parse/t_program.h??
?? compiler/cpp/src/platform.h??
?? compiler/cpp/src/thriftl.ll??
?? compiler/cpp/src/thrifty.yy??
?? lib/netstd/src/Protocol/TBinaryProtocol.cs??
?? lib/netstd/src/Protocol/TField.cs??
?? lib/netstd/src/Protocol/TList.cs??
?? lib/netstd/src/Protocol/TMap.cs??
?? lib/netstd/src/Protocol/TMessage.cs??
?? lib/netstd/src/Protocol/TMessageType.cs??
?? lib/netstd/src/Protocol/TProtocol.cs??
?? lib/netstd/src/Protocol/TProtocolException.cs??
?? lib/netstd/src/Protocol/TProtocolFactory.cs??
?? lib/netstd/src/Protocol/TProtocolUtil.cs??
?? lib/netstd/src/Protocol/TSet.cs??
?? lib/netstd/src/Protocol/TStruct.cs??
?? lib/netstd/src/Protocol/TType.cs??
?? lib/netstd/src/Server/TServer.cs??
?? lib/netstd/src/Server/TSimpleServer.cs??
?? lib/netstd/src/Server/TThreadPoolServer.cs??
?? lib/netstd/src/TApplicationException.cs??
?? lib/netstd/src/Thrift.csproj??
?? lib/netstd/src/Thrift.sln??
?? lib/netstd/src/TProcessor.cs??
?? lib/netstd/src/Transport/TServerSocket.cs??
?? lib/netstd/src/Transport/TServerTransport.cs??
?? lib/netstd/src/Transport/TSocket.cs??
?? lib/netstd/src/Transport/TStreamTransport.cs??
?? lib/netstd/src/Transport/TTransport.cs??
?? lib/netstd/src/Transport/TTransportException.cs??
?? lib/netstd/src/Transport/TTransportFactory.cs??
?? lib/netstd/ThriftMSBuildTask/Properties/AssemblyInfo.cs??
?? lib/netstd/ThriftMSBuildTask/ThriftBuild.cs??
?? lib/netstd/ThriftMSBuildTask/ThriftMSBuildTask.csproj??
?? lib/rb/lib/thrift.rb??
?? lib/st/README??
?? lib/st/thrift.st??
?? test/OptionalRequiredTest.cpp??
?? test/OptionalRequiredTest.thrift??
?? test/ThriftTest.thrift??

 

3. The file says

 

??For the compiler/cpp/src/md5.[ch] components:??

 

but there is no md5-related file in 
[compiler/cpp/src/|[https://github.com/apache/thrift/tree/master/compiler/cpp/src].]

 

4. The file says

??For the lib/rb/setup.rb: Copyright (c) 2000-2005 Minero Aoki,??

but there is no setup.rb file in 
[lib/rb/|[https://github.com/apache/thrift/tree/master/lib/rb].]

 

5. The file says

??lib/ocaml/OCamlMakefile and lib/ocaml/README-OCamlMakefile components:??

but both files do not exist.

 

6. The file says

??(see doc/lgpl-2.1.txt for the full terms of this license)??

but the correct path is 
[doc/licenses/lgpl-2.1.txt|[https://github.com/apache/thrift/blob/master/doc/licenses/lgpl-2.1.txt].]

 

??Please see doc/otp-base-license.txt for the full terms of this license.??

but the correct path is 
[doc/licenses/otp-base-license.txt|[https://github.com/apache/thrift/blob/master/doc/licenses/otp-base-license.txt].]

 

??The following files contain some portions of code contributed under??
??the Thrift Software License (see doc/old-thrift-license.txt), and relicensed??
??under the Apache 2.0 License:??

but cannot find old-thrift-license.txt file in doc/ or doc/licenses.

 

 

 


> Update debian/copyright
> -----------------------
>
>                 Key: THRIFT-5348
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5348
>             Project: Thrift
>          Issue Type: Documentation
>            Reporter: Jihoon Seo
>            Priority: Trivial
>              Labels: doc, documentation, license
>
> In 
> [debian/copyright|https://github.com/apache/thrift/blob/master/debian/copyright],
>  
> 1. The file says
> ??Portions of the following files are licensed under the MIT License:??
> ??lib/erl/src/Makefile.am??
>  
> but there is no Makefile.am in 
> [lib/erl/src/|https://github.com/apache/thrift/tree/master/lib/erl/src].
>  
> Instead, there exists 
> [lib/erl/Makefile.am|https://github.com/apache/thrift/blob/master/lib/erl/Makefile.am].
>  
> 2. These paths need to be checked and updated.
>  
> ?? compiler/cpp/Makefile.am??
>  ?? compiler/cpp/src/generate/t_cpp_generator.cc??
>  ?? compiler/cpp/src/generate/t_netstd_generator.cc??
>  ?? compiler/cpp/src/generate/t_erl_generator.cc??
>  ?? compiler/cpp/src/generate/t_hs_generator.cc??
>  ?? compiler/cpp/src/generate/t_java_generator.cc??
>  ?? compiler/cpp/src/generate/t_ocaml_generator.cc??
>  ?? compiler/cpp/src/generate/t_perl_generator.cc??
>  ?? compiler/cpp/src/generate/t_php_generator.cc??
>  ?? compiler/cpp/src/generate/t_py_generator.cc??
>  ?? compiler/cpp/src/generate/t_rb_generator.cc??
>  ?? compiler/cpp/src/generate/t_st_generator.cc??
>  ?? compiler/cpp/src/generate/t_xsd_generator.cc??
>  ?? compiler/cpp/src/main.cc??
>  ?? compiler/cpp/src/parse/t_field.h??
>  ?? compiler/cpp/src/parse/t_program.h??
>  ?? compiler/cpp/src/platform.h??
>  ?? compiler/cpp/src/thriftl.ll??
>  ?? compiler/cpp/src/thrifty.yy??
>  ?? lib/netstd/src/Protocol/TBinaryProtocol.cs??
>  ?? lib/netstd/src/Protocol/TField.cs??
>  ?? lib/netstd/src/Protocol/TList.cs??
>  ?? lib/netstd/src/Protocol/TMap.cs??
>  ?? lib/netstd/src/Protocol/TMessage.cs??
>  ?? lib/netstd/src/Protocol/TMessageType.cs??
>  ?? lib/netstd/src/Protocol/TProtocol.cs??
>  ?? lib/netstd/src/Protocol/TProtocolException.cs??
>  ?? lib/netstd/src/Protocol/TProtocolFactory.cs??
>  ?? lib/netstd/src/Protocol/TProtocolUtil.cs??
>  ?? lib/netstd/src/Protocol/TSet.cs??
>  ?? lib/netstd/src/Protocol/TStruct.cs??
>  ?? lib/netstd/src/Protocol/TType.cs??
>  ?? lib/netstd/src/Server/TServer.cs??
>  ?? lib/netstd/src/Server/TSimpleServer.cs??
>  ?? lib/netstd/src/Server/TThreadPoolServer.cs??
>  ?? lib/netstd/src/TApplicationException.cs??
>  ?? lib/netstd/src/Thrift.csproj??
>  ?? lib/netstd/src/Thrift.sln??
>  ?? lib/netstd/src/TProcessor.cs??
>  ?? lib/netstd/src/Transport/TServerSocket.cs??
>  ?? lib/netstd/src/Transport/TServerTransport.cs??
>  ?? lib/netstd/src/Transport/TSocket.cs??
>  ?? lib/netstd/src/Transport/TStreamTransport.cs??
>  ?? lib/netstd/src/Transport/TTransport.cs??
>  ?? lib/netstd/src/Transport/TTransportException.cs??
>  ?? lib/netstd/src/Transport/TTransportFactory.cs??
>  ?? lib/netstd/ThriftMSBuildTask/Properties/AssemblyInfo.cs??
>  ?? lib/netstd/ThriftMSBuildTask/ThriftBuild.cs??
>  ?? lib/netstd/ThriftMSBuildTask/ThriftMSBuildTask.csproj??
>  ?? lib/rb/lib/thrift.rb??
>  ?? lib/st/README??
>  ?? lib/st/thrift.st??
>  ?? test/OptionalRequiredTest.cpp??
>  ?? test/OptionalRequiredTest.thrift??
>  ?? test/ThriftTest.thrift??
>  
> 3. The file says
>  
> ??For the compiler/cpp/src/md5.[ch] components:??
>  
> but there is no md5-related file in 
> [compiler/cpp/src/|https://github.com/apache/thrift/tree/master/compiler/cpp/src].
>  
> 4. The file says
> ??For the lib/rb/setup.rb: Copyright (c) 2000-2005 Minero Aoki,??
> but there is no setup.rb file in 
> [lib/rb/|https://github.com/apache/thrift/tree/master/lib/rb].
>  
> 5. The file says
> ??lib/ocaml/OCamlMakefile and lib/ocaml/README-OCamlMakefile components:??
> but both files do not exist.
>  
> 6. The file says
> ??(see doc/lgpl-2.1.txt for the full terms of this license)??
> but the correct path is 
> [doc/licenses/lgpl-2.1.txt|https://github.com/apache/thrift/blob/master/doc/licenses/lgpl-2.1.txt].
>  
> ??Please see doc/otp-base-license.txt for the full terms of this license.??
> but the correct path is 
> [doc/licenses/otp-base-license.txt|https://github.com/apache/thrift/blob/master/doc/licenses/otp-base-license.txt].
>  
> ??The following files contain some portions of code contributed under??
>  ??the Thrift Software License (see doc/old-thrift-license.txt), and 
> relicensed??
>  ??under the Apache 2.0 License:??
> but cannot find old-thrift-license.txt file in doc/ or doc/licenses.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to