[ https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287596#comment-17287596 ]
Jens Geyer edited comment on THRIFT-5358 at 2/20/21, 8:51 AM: -------------------------------------------------------------- [thrift/ReleaseManagement.md at master · apache/thrift (github.com)|https://github.com/apache/thrift/blob/master/doc/ReleaseManagement.md] when you write "we" - do you mean that or do you really mean "someone other than you"? we will very liklely have a0.14.0.1 but certainly not "quick". Because then tghe next thing I will hear is "oh we need a 0.14.0.2 quick" was (Author: jensg): [thrift/ReleaseManagement.md at master · apache/thrift (github.com)|https://github.com/apache/thrift/blob/master/doc/ReleaseManagement.md] when you write "we" - do you mean that or do you really mean "someone other than you"? > Add go.mod file(s) > ------------------ > > Key: THRIFT-5358 > URL: https://issues.apache.org/jira/browse/THRIFT-5358 > Project: Thrift > Issue Type: Task > Components: Go - Library > Affects Versions: 0.14.0 > Reporter: Yuxuan Wang > Priority: Major > > Go 1.16 already disallowed building without go.mod file by default (still > override-able with GO111MODULES=auto environment variable), and Go 1.17 will > remove that override option, so we need to add go.mod file(s) to unblock > developers working on tip and using Go 1.16+. > Based on the current discussion on https://github.com/golang/go/issues/34055, > we probably will need to add 2 go.mod files: > # one under lib/go/thrift for our users to use. A release process change is > also required because of this file: for all the future releases, we would > need to double tag with "lib/go/thrift/" prefix (e.g. for 0.15.0 release we > would need to git tag "v0.15.0" and "lib/go/thrift/v0.15.0" on the same > commit) > # another under root for the tests to work on Go 1.16+ -- This message was sent by Atlassian Jira (v8.3.4#803005)