emmenlau opened a new pull request #2382:
URL: https://github.com/apache/thrift/pull/2382


   This PR adds support for loading SSL certificates from a memory buffer. This 
is helpful when the certificate is built into the application (i.e. as a 
`char*` or similar mechanism).
   
   The PR also adds a slight improvement with respect to calling `free()` in 
case of error. There are two cases where the current implementation does not 
call `free()` on the buffer in case of error. These cases are addressed here.
   
   - [ ] Did you create an [Apache 
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not 
required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern 
"THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but 
preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, 
did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere 
in the commit message to free up build resources.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to