[
https://issues.apache.org/jira/browse/THRIFT-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5419.
--------------------------------
Fix Version/s: 0.15.0
Resolution: Fixed
> Incorrect usage of thread pool in TThreadPoolAsyncServer may lead to poor
> performance
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-5419
> URL: https://issues.apache.org/jira/browse/THRIFT-5419
> Project: Thrift
> Issue Type: Bug
> Components: netstd - Library
> Affects Versions: 0.14.1
> Environment: Windows 10 with Visual Studio 2019.
> Reporter: Nathan P Sharp
> Assignee: Nathan P Sharp
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> *Abstract:*
> TThreadPoolAsyncServer uses ThreadPool.QueueUserWorkItem for each incoming
> connection to post a long-lived, synchronous task to the thread pool. This
> causes deadlock in the thread pool, which is only designed for short lived
> tasks, and can cause dramatic poor performance throughout your application,
> even in unrelated areas.
> *Details:*
> The .NET Thread Pool is not designed to handle long lived tasks. It has a
> complex set of logic that starts the pool at a size based on available CPUs
> and memory, then automatically grows it if it detects deadlock (no tasks
> completed for a second). Let's say that number is 4, as soon as you have 4
> concurrent connections, everything in your process will come grinding to a
> halt until a second has passed and it grows the pool. This will affect
> everything in your process, even seemingly unrelated code and can have
> dramatic bad effects on performance.
> *Fix:*
> There are a number of fixes possible, but the most efficient and best is to
> use async/await to rewrite Execute() as asynchronous.
> *Other side effects:*
> Execute has a catch(TTransportException) block which I suspect will never be
> hit. Calling .Wait() and/or .Result always wraps exceptions in an
> AggregateException. A properly written async/await version would unwrap that
> exception for you.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
