+1, but I also would suggest to cherry pick https://github.com/apache/thrift/commit/6583f4e52345c3b05a76f0b188836599628356e8 into the 0.14.2 branch.
The background to that commit is that jaeger project () was hit by that issue, and they currently use a forked thrift with 0.14.1 plus cherry-picked that commit to resolve the issue [0]. So including it into 0.14.2 release would help them to switch back to mainline release. [0]: https://github.com/jaegertracing/thrift/commits/v0.14.1-patch1 On Fri, Jun 11, 2021 at 12:15 PM Jens Geyer <je...@apache.org> wrote: > All, > > I propose that we accept the following release candidate as the official > Apache Thrift 0.14.2 release: > > > https://dist.apache.org/repos/dist/dev/thrift/0.14.2-rc0/thrift-0.14.2.tar.gz > > The release candidate was created from the 0.14.2 branch and can be cloned > using: > > git clone -b 0.14.2 https://github.com/apache/thrift.git > > The release candidates GPG signature can be found at: > > https://dist.apache.org/repos/dist/dev/thrift/0.14.2-rc0/thrift-0.14.2.tar.gz.asc > > The release candidates checksums are: > md5: b173bd59328dd2a970dc8be2f5d2fe568653ef05 > sha1: 357e5bf32d6d4ffc8d18d428d954591a > sha256: 2ebe48549359430c60289a52053baa283baddf9b94d2c60f72afed7faba2ab8b > > > A prebuilt Windows compiler is available at: > https://dist.apache.org/repos/dist/dev/thrift/0.14.2-rc0/thrift-0.14.2.exe > > Prebuilt Windows compiler GPG signature: > > https://dist.apache.org/repos/dist/dev/thrift/0.14.2-rc0/thrift-0.14.2.exe.asc > > Prebuilt Windows compiler checksums are: > md5: fd0bda468e65f552e15a585ef5de83fe > sha1: 52a0a177cea7d5431fa5b19d8d6caa753b02eba1 > sha256: 2a0911dbd5899ebb37a08dcc517188ce02987cdebdfc5e5f1db29215ed5355bb > > > The CHANGES list for this release is available at: > https://github.com/apache/thrift/blob/0.14.2/CHANGES.md > > > Please download, verify sig/sum, install and test the libraries and > languages of your choice. > > This vote will close in 76 hours on Thu, 2021-06-17 00:00 UTC > https://www.timeanddate.com/countdown/generic?iso=20210617T0000&p0=1440 > > [ ] +1 Release this as Apache Thrift 0.14.2 > [ ] +0 > [ ] -1 Do not release this as Apache Thrift 0.14.2 because... > > Best, > JensG > >
