[ 
https://issues.apache.org/jira/browse/THRIFT-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391069#comment-17391069
 ] 

Jens Geyer commented on THRIFT-5444:
------------------------------------

Since I already rewrote that args/result stuff a while ago (it now 
"deconflicts" by using some {{InternalStruct}}) I was able to simply get rid of 
that special case, rectify a few things along the way and had the patch ready. 
Test case included.

> Netstd generator produces uncompileable code for enums ending with "_result" 
> or "_args"
> ---------------------------------------------------------------------------------------
>
>                 Key: THRIFT-5444
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5444
>             Project: Thrift
>          Issue Type: Bug
>          Components: netstd - Compiler
>    Affects Versions: 0.14.2
>            Reporter: Triton Circonflexe
>            Assignee: Jens Geyer
>            Priority: Major
>         Attachments: enum_result.tbz2
>
>
> When the .thrift files contains an enumeration whose name contains "_result", 
> the generated code contains "Result" except in the definition of the enum 
> itself, preventing the code from compiling successfully.
> Since other enumerations are generated preserving the case and underscores, I 
> believe the issue lies on the usage side and not definition.
> Provided example (generated with {{netstd:no_deepcopy}}) shows the case where 
> the enum in used as a return value but the issue is the same when used as 
> parameter or inside a struct.
> I observed this issue with the current HEAD and checked that it already 
> existed in 0.14.2.
> I will take a look and try to propose a patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to