Dear Thrift developers,
I've completed a large update of the AppVeyor build instructions. It would be great to get some feedback. Most importantly, MSVC builds did not execute any tests in the past, possibly for a long time. This has been fixed - the ctest exclude regexp was set to empty which excludes all tests :-( The PR is here: https://github.com/apache/thrift/pull/2429 The main changes to AppVeyor build are: - Instructions are much shorter: Many older workarounds are not needed any more and have been removed. - The steps for setup, install, build and test have been unified into a single step. This reduces some platforms from making 10+ batch-file- calls to a single instruction set of less than 100 lines. I hope that this improves maintainability. - The build will no longer abort other platforms when one platform fails. This is because the Thrift project has relatively often one or two broken builds, but users should still get feedback on their PRs from the remaining platforms. On the other hand, it may waste a bit of AppVeyor time, but I think it is the better compromise. - The Cygwin build has been failing since a long time (probably more than 6 months). I could not fix that, so Cygwin is disabled for now. - Since Windows tests are re-enabled, there is now one failing test. Its from THRIFT-3840. Previously the test was not executed and so the error was not visible. I would still merge my PR, and fix the test independently later. Please let me know what you think? I hope to merge this soon because it fixes Windows tests. All the best, Mario On 05.08.21 11:53, Mario Emmenlauer wrote: > > Dear Thrift developers, > > I've concerned myself with the AppVeyor build instructions just because > a number of recent builds had failed. Now I'm under the impression that > the build instructions can use a bit of love and cleanup. > > I've started to work on the build in the following PR: > https://github.com/apache/thrift/pull/2429 > > Since more and more changes and cleanup accumulate, I wanted to kindly > ping you all and ask if anyone has _objections_ to this cleanup? > > My intention is to make the code as readable as possible, remove older > workarounds that are likely not needed anymore, and follow the current > AppVeyor documentation closely (replacing older instructions where > newer ones exist). > > So please ping me (as soon as possible) if you have objections or > suggestions for this cleanup. > > All the best, > > Mario Emmenlauer
