emmenlau opened a new pull request #2447: URL: https://github.com/apache/thrift/pull/2447
Currently the cmake-generated header `config.h` is not used on MSVC. However it can be helpful to have the option to use this header, for example to detect the presence of newer Windows SDK features (like used in https://github.com/apache/thrift/pull/2327). I've tested this addition for over a year successfully on various combinations of Windows and did not find any issues or problems. I've also tried to make sure that previous Windows defines remain available unless overridden by cmake (which should be a good thing). - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
