Tian Jiang created THRIFT-5502:
----------------------------------
Summary: Is it necessary to report CONNECTION RESET as an ERROR?
Key: THRIFT-5502
URL: https://issues.apache.org/jira/browse/THRIFT-5502
Project: Thrift
Issue Type: Improvement
Components: Java - Library
Affects Versions: 0.14.1, 0.14.0
Reporter: Tian Jiang
Attachments: image-2022-01-21-18-20-10-995.png,
image-2022-01-21-18-26-54-640.png
I notice that in your Java implementation if a connection throws an exception,
you will log it or not depending on the type of the exception. Currently, only
two kinds of exceptions will be ignored: TIME_OUT and EOF.
!image-2022-01-21-18-20-10-995.png!
However, a common case is when a client exits without closing the connection
properly, the server will receive CONNECTION RESET instead of EOF. It is very
likely that human users will close client programs directly rather than use
some "exit" command.
!image-2022-01-21-18-26-54-640.png!
I understand that it is arguable whether an abnormally-exit client should be
reported. But in my opinion, it should at least not generate an ERROR log, as
ERROR logs are very sensitive in production systems and may trigger further
alerts, while an abnormally-exit client is not actually some error that should
be handled by the server maintainers.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
